Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dependency on System.Reflection.Metadata to RuntimeConfigParser task #56152

Merged
merged 5 commits into from
Jul 23, 2021

Conversation

directhex
Copy link
Contributor

Closes: #55277

@ghost
Copy link

ghost commented Jul 22, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes: #55277

Author: directhex
Assignees: -
Labels:

area-System.Net

Milestone: -

Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the RuntimeConfigTask with the contents of this PR and it seems to fix the issue.

If you merge with main, it'll fix the build issue you are seeing.

@steveisok steveisok changed the title Add explicit dependency on System.Reflection.Metadata to MonoTargets. Add explicit dependency on System.Reflection.Metadata to RuntimeConfigParser task Jul 23, 2021
@steveisok steveisok merged commit bd3fb96 into dotnet:main Jul 23, 2021
@steveisok
Copy link
Member

/backport to release/6.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview7: https://github.com/dotnet/runtime/actions/runs/1059970210

@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeConfigParserTask fails in .NET framework MSBuild
4 participants